Bug #38

CheckDeviceChangeEvents doesn't check triggers?

Added by Anonymous over 3 years ago. Updated over 3 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:rdnzl% Done:

0%

Category:-
Target version:-
Resolution:fixed

Description

It seems to me (after checking the source) that CheckDeviceChangeEvents doesn't check the triggers anymore and starts doing the events right away.
In previous versions the triggers where checked, but now they are not, or am i missing something?
It noticed because the events for 'value=on' and 'value=off' where triggered both when the device status changed.

History

#1 Updated by rdnzl over 3 years ago

You are correct I think, another users suspected a problem with event triggers too, being triggered always... Will look into this and let you know. Thanks for the bugreport/pointer.

#2 Updated by Anonymous over 3 years ago

Some prelimenary testing tells me it's working again, so no double switch on and off.
Numeric comparisons don't work yet however, but this brings back the little comfort-things I was missing :)

#3 Updated by rdnzl over 3 years ago

I will check what the reason is for the numeric comparison bug.

#4 Updated by Anonymous over 3 years ago

Numeric comparisons was my problem too, see http://domoticaforum.eu/viewtopic.php?f=38&t=5393
I think Ron is about to applie my fix.

#5 Updated by rdnzl over 3 years ago

  • Resolution set to fixed

I have just uploaded some Events bugfixes to r419.
Turned out that the patch given didn't work correctly with floats ie 31.122 Watts.
Now after trying and testing it works on all occasions with even less code than before ;-)

[Events] Check condition 33 < 40 = True
[Events] Check condition 33 > 40 = False
[Events] Check condition 33 > 22.411 = True
[Events] Check condition 11 < 22.411 = True
[Events] Check condition 33 = 33 = True
[Events] Check condition 33 <> 33 = False
[Events] Check condition 33 <> 31 = True
[Events] Check condition test = test = True
[Events] Check condition test = Test = False
[Events] Check condition test <> Test = True
[Events] Check condition True = True = True
[Events] Check condition True = False = False
[Events] Check condition False = False = True
[Events] Invalid comparison in [[CheckCondition]]() routine!
(when trying to do invalid things like IF "Test" > "test" THEN)
[Events] Check condition 35.739 < 30 = False

Also available in: Atom PDF